Skip to content

Add Schema Compare Controller Logic #18619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lewis-sanchez merged 34 commits into from
Feb 11, 2025
Merged

Add Schema Compare Controller Logic #18619

lewis-sanchez merged 34 commits into from
Feb 11, 2025

Conversation

@lewis-sanchez
Copy link
Contributor

@lewis-sanchez lewis-sanchez commented Feb 5, 2025

This PR adds controller logic for Schema Compare.

The bulk of the logic here is for the controller with minimal UI logic to create this placeholder page:
image

@lewis-sanchez
Set up schema compare page
cb30533
@lewis-sanchez
Localized strings
8d061b9
@lewis-sanchez
Add schema compare contracts and endpoints
ac6c44b
@lewis-sanchez
Add schema compare icons
f64c1f9
@lewis-sanchez
Use schema compare icon in webview.
6cd7f33
@lewis-sanchez
Add init logic for SC webview controller
2fb9256
@lewis-sanchez
Defines and registers reducers
8d68dfb
@lewis-sanchez
Merge branch 'main' into lewissanchez/feat/schemaCompare
c8ad560 
# Conflicts:
#	gulpfile.js
#	src/controllers/mainController.ts
#	src/services/schemaCompareService.ts
#	typings/vscode-mssql.d.ts
@lewis-sanchez
Remove unwanted change
c526d32
@lewis-sanchez
Define and implement schame compare state provider
2d4e878
@lewis-sanchez
Fix controller init logic
e9b1fb3
@lewis-sanchez
Add SQL Projects schema compare entry point
71dc730
@lewis-sanchez
Get full SQL projects path
88f6be6
@lewis-sanchez
Setup controller for tests
cdbc5dc
@lewis-sanchez
Add basic test
e039089
@lewis-sanchez
Add schema compare controller unit tests
722f683
@lewis-sanchez
Add more tests for SchemaCompare controller tests
7666686
@lewis-sanchez
Add additional tests to verify results
d396aa4
@lewis-sanchez lewis-sanchez requested a review from a user February 5, 2025 20:05
@lewis-sanchez lewis-sanchez requested a review from Benjin as a code owner February 5, 2025 20:05
lewis-sanchez
lewis-sanchez commented Feb 5, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Feb 5, 2025 •
edited
Loading

PR Changes

Category Main Branch PR Branch Difference
Code Coverage 50.45% 50.73% $${\color{lightgreen} .28\% }$$
VSIX Size 12144 KB 12150 KB $${\color{lightgreen} 6 KB \space (0\%) }$$
Webview Bundle Size 3176 KB 3188 KB $${\color{lightgreen} 12 KB \space (0\%) }$$

Benjin
Benjin reviewed Feb 6, 2025
View reviewed changes
Benjin
Benjin reviewed Feb 6, 2025
View reviewed changes
@lewis-sanchez lewis-sanchez requested a review from Benjin February 11, 2025 17:25
Benjin
Benjin reviewed Feb 11, 2025
View reviewed changes
@lewis-sanchez lewis-sanchez requested a review from Benjin February 11, 2025 21:59
@lewis-sanchez lewis-sanchez merged commit e357f6d into main Feb 11, 2025
6 checks passed
@lewis-sanchez lewis-sanchez deleted the lewissanchez/feat/schemaCompare branch February 11, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Benjin Benjin Benjin approved these changes

@kburtram kburtram Awaiting requested review from kburtram kburtram is a code owner

@aasimkhan30 aasimkhan30 Awaiting requested review from aasimkhan30 aasimkhan30 is a code owner

@cssuh cssuh Awaiting requested review from cssuh

@caohai caohai Awaiting requested review from caohai caohai is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lewis-sanchez @Benjin